From f09c6249884aef5d1a006b216b6435738b18d5f8 Mon Sep 17 00:00:00 2001
From: Shawfix <shawliu996@gmail.com>
Date: Fri, 22 Aug 2025 15:00:24 +0800
Subject: [PATCH] optimize(infra): remove tautological condition (#856)

---
 backend/infra/impl/storage/s3/s3.go | 20 ++++++++------------
 1 file changed, 8 insertions(+), 12 deletions(-)

diff --git a/backend/infra/impl/storage/s3/s3.go b/backend/infra/impl/storage/s3/s3.go
index ea3ec5b3..3e5025ee 100644
--- a/backend/infra/impl/storage/s3/s3.go
+++ b/backend/infra/impl/storage/s3/s3.go
@@ -138,21 +138,17 @@ func (t *s3Client) CheckAndCreateBucket(ctx context.Context) error {
 		return nil // already exist
 	}
 
-	if err != nil {
-		// bucket not exist
-		if awsErr, ok := err.(interface{ ErrorCode() string }); ok && awsErr.ErrorCode() == "404" {
-			input := &s3.CreateBucketInput{
-				Bucket: aws.String(bucket),
-			}
-			// create bucket
-			_, err := client.CreateBucket(ctx, input)
-			return err
-		}
-		// other case
+	awsErr, ok := err.(interface{ ErrorCode() string })
+	if !ok || awsErr.ErrorCode() != "404" {
 		return err
 	}
 
-	return nil
+	// bucket not exist
+	input := &s3.CreateBucketInput{
+		Bucket: aws.String(bucket),
+	}
+	_, err = client.CreateBucket(ctx, input)
+	return err
 }
 
 func (t *s3Client) PutObject(ctx context.Context, objectKey string, content []byte, opts ...storage.PutOptFn) error {